docs(linux): J784S4: Add the PCIe boot documentation#535
Open
hrushikesh221 wants to merge 1 commit intoTexasInstruments:masterfrom
Open
docs(linux): J784S4: Add the PCIe boot documentation#535hrushikesh221 wants to merge 1 commit intoTexasInstruments:masterfrom
hrushikesh221 wants to merge 1 commit intoTexasInstruments:masterfrom
Conversation
hrushikesh221
requested review from
StaticRocket,
VeeruPrudhvi,
aniket-l,
cshilwant,
praneethbajjuri and
uditkumarti
as code owners
github-actions
bot
assigned
bryanbrattlof,
devarsht,
jmenti,
praneethbajjuri,
r-vignesh and
uditkumarti
github-actions
bot
requested review from
bryanbrattlof,
devarsht,
jmenti and
r-vignesh
StaticRocket
requested changes
Dec 1, 2025
Member
StaticRocket
left a comment
StaticRocket
left a comment
There was a problem hiding this comment.
Some vale comments are still pending
hrushikesh221
force-pushed
the
pcie_boot
branch
from
7823f56 to
9944e65
Compare
Add PCIe boot documentation for J784S4. While at it also add more details to PCIe boot procedure. Signed-off-by: Hrushikesh Salunke <h-salunke@ti.com>
hrushikesh221
force-pushed
the
pcie_boot
branch
from
9944e65 to
d82a541
Compare
Contributor
Author
|
@StaticRocket thanks for the feedback. I have resolved the vale comments. |
StaticRocket
reviewed
Dec 2, 2025
| @@ -174,6 +288,7 @@ appropriate memory regions using ``/dev/mem``. | |||
| int main(int argc, char *argv[]) | |||
Member
There was a problem hiding this comment.
Well, I was going to say:
- We probably shouldn't include demo code in the documentation, it should be hosted somewhere we can point people to.
- RST supports including arbitrary files as
codeby using the:code:flag on theincludedirective. It says it's supposed to support syntax highlighting, but that doesn't seem to be true. May need to open a bug upstream about that.
So, yeah, I guess this is fine for now.
StaticRocket
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add PCIe boot documentation for J784S4. While at it also add more details to PCIe boot procedure.